Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 9837114: Makes the frame maximize button show the multi-state icon on hover. (Closed)

Created:
8 years, 9 months ago by sky
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Makes the frame maximize button show the multi-state icon on hover. BUG=120514 TEST=see bug R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ash/wm/workspace/frame_maximize_button.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
8 years, 9 months ago (2012-03-28 16:24:55 UTC) #1
Ben Goodger (Google)
8 years, 9 months ago (2012-03-28 16:54:06 UTC) #2
LGTM

On Wed, Mar 28, 2012 at 9:24 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Makes the frame maximize button show the multi-state icon on hover.
>
> BUG=120514
> TEST=see bug
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/9837114/<http://codereview.chromium.org/9837...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/wm/workspace/frame_**maximize_button.cc
>
>
> Index: ash/wm/workspace/frame_**maximize_button.cc
> diff --git a/ash/wm/workspace/frame_**maximize_button.cc
> b/ash/wm/workspace/frame_**maximize_button.cc
> index 49e4a611fa5f347677a50cdbd0e13c**912a890306..**
> f4572d3684ddd7411b3ef6f96285a4**7388e1b40d 100644
> --- a/ash/wm/workspace/frame_**maximize_button.cc
> +++ b/ash/wm/workspace/frame_**maximize_button.cc
> @@ -213,6 +213,9 @@ SkBitmap FrameMaximizeButton::**GetImageToPaint() {
>       }
>     }
>     return *ResourceBundle::**GetSharedInstance().**
> GetImageNamed(id).ToSkBitmap()**;
> +  } else if (state() == BS_HOT) {
> +    return *ResourceBundle::**GetSharedInstance().**GetImageNamed(
> +        IDR_AURA_WINDOW_MAXIMIZED_**RESTORE_SNAP_P).ToSkBitmap();
>   }
>   return ImageButton::GetImageToPaint()**;
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698