Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 9837095: [Coverity] Fixed frame size (Closed)

Created:
8 years, 9 months ago by wjia(left Chromium)
Modified:
8 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

[Coverity] Fixed frame size It's wrong to use sizeof(pointer) to get the size of video frame. Need remember the frame size when it's allocated. CID=100299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/video/capture/fake_video_capture_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wjia(left Chromium)
8 years, 9 months ago (2012-03-27 23:41:51 UTC) #1
scherkus (not reviewing)
Wei please include more informative CL descriptions. "correct frame size" contains no details as to ...
8 years, 9 months ago (2012-03-28 00:12:14 UTC) #2
scherkus (not reviewing)
8 years, 9 months ago (2012-03-28 00:22:13 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698