Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 9837094: Fix warning-as-error for NaCl integration (Closed)

Created:
8 years, 9 months ago by nfullagar
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix warning-as-error for NaCl integration BUG=none TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129445

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_net_address_private_rpc_server.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nfullagar
8 years, 9 months ago (2012-03-27 23:16:06 UTC) #1
bbudge
lgtm
8 years, 9 months ago (2012-03-27 23:24:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/9837094/1
8 years, 9 months ago (2012-03-27 23:26:03 UTC) #3
commit-bot: I haz the power
Try job failure for 9837094-1 (previous was lost) on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=4749 Step ...
8 years, 9 months ago (2012-03-27 23:57:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/9837094/1
8 years, 9 months ago (2012-03-28 00:03:15 UTC) #5
commit-bot: I haz the power
Try job failure for 9837094-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=14809 Step "update" is always ...
8 years, 9 months ago (2012-03-28 00:11:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/9837094/2006
8 years, 9 months ago (2012-03-28 04:57:22 UTC) #7
commit-bot: I haz the power
Try job failure for 9837094-2006 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-28 07:31:27 UTC) #8
nfullagar
Committed revision 129445.
8 years, 9 months ago (2012-03-28 18:17:25 UTC) #9
jvoung - send to chromium...
8 years, 9 months ago (2012-03-28 19:57:30 UTC) #10
Hmm I tried to reduce these issues by enabling warning-as-errors in gyp:

http://codereview.chromium.org/9355030

but maybe there are other issues (like debug build vs release builds) =(

Powered by Google App Engine
This is Rietveld 408576698