chrome/browser/prerender/prerender_contents.cc - Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Revised approach based on http://crrev.com/125180. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prerender/prerender_contents.cc

diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc

index 9919e744d5109753579b0bcae902aad1a020a64e..62b1576b0243d209c3df6f1b7e9c5e04f5eaf7b4 100644

--- a/chrome/browser/prerender/prerender_contents.cc

+++ b/chrome/browser/prerender/prerender_contents.cc

@@ -154,7 +154,8 @@ class PrerenderContents::TabContentsDelegateImpl

WebContents* web_contents,

int route_id,

WindowContainerType window_container_type,

- const string16& frame_name) OVERRIDE {

+ const string16& frame_name,

+ const GURL& target_url) OVERRIDE {

// Since we don't want to permit child windows that would have a

// window.opener property, terminate prerendering.

prerender_contents_->Destroy(FINAL_STATUS_CREATE_NEW_WINDOW);

« no previous file with comments | « chrome/browser/extensions/app_background_page_apitest.cc ('k') | chrome/browser/ui/browser.h » ('j') | chrome/browser/ui/browser.cc » ('J')