Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Unified Diff: content/renderer/render_view_impl.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 5a016ac64d916b62eba021569304463e33bbb5b8..98ebc5ab0ee946c10fbefbd93f3144b5e489a5b8 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1481,12 +1481,14 @@ WebView* RenderViewImpl::createView(
int32 routing_id = MSG_ROUTING_NONE;
int32 surface_id = 0;
int64 cloned_session_storage_namespace_id;
+ bool no_js_access;
RenderThread::Get()->Send(
new ViewHostMsg_CreateWindow(params,
&routing_id,
&surface_id,
- &cloned_session_storage_namespace_id));
+ &cloned_session_storage_namespace_id,
+ &no_js_access));
if (routing_id == MSG_ROUTING_NONE)
return NULL;
@@ -1521,7 +1523,7 @@ WebView* RenderViewImpl::createView(
// the new render view (we don't need the browser to send the URL back down).
view->alternate_error_page_url_ = alternate_error_page_url_;
- return view->webview();
+ return no_js_access ? NULL : view->webview();
}
WebWidget* RenderViewImpl::createPopupMenu(WebKit::WebPopupType popup_type) {

Powered by Google App Engine
This is Rietveld 408576698