Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 9837065: Use shadows on launcher icons (Closed)

Created:
8 years, 9 months ago by DaveMoore
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Use shadows on launcher icons BUG=119848 TEST=Visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128611

Patch Set 1 #

Patch Set 2 : Remove extraneous canvas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M ash/launcher/launcher_button.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/launcher/launcher_button.cc View 1 4 chunks +34 lines, -7 lines 0 comments Download
M ui/resources/aura/launcher_browser.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/aura/launcher_browser_panel.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/aura/launcher_incognito_browser.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/aura/launcher_incognito_browser_panel.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaveMoore
8 years, 9 months ago (2012-03-23 22:28:58 UTC) #1
sky
8 years, 9 months ago (2012-03-23 23:23:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698