Issue 9837060: Treat EAGAIN/EWOULDBLOCK as requests for retry on socket accept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9837060: Treat EAGAIN/EWOULDBLOCK as requests for retry on socket accept. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)

Modified:
8 years, 9 months ago

Reviewers:
Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Treat EAGAIN/EWOULDBLOCK as requests for retry on socket accept. On Linux there are a number of protocol errors that can be returned from accept. According to the linux man pages they should be treated as EAGAIN. This should hopefully fix the flakiness of EchoServerStreamTest. R=iposva@google.com,sgjesse@google.com BUG=2262 TEST= Committed: https://code.google.com/p/dart/source/detail?r=5797

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove error printing #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -5 lines)			Patch
M	runtime/bin/socket.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/socket.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_impl.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/bin/socket_linux.cc	View	1	1 chunk	+19 lines, -2 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 9 months ago (2012-03-23 21:09:48 UTC) #2

LGTM -ip

https://chromiumcodereview.appspot.com/9837060/diff/1/runtime/bin/socket_linu...
File runtime/bin/socket_linux.cc (right):

https://chromiumcodereview.appspot.com/9837060/diff/1/runtime/bin/socket_linu...
runtime/bin/socket_linux.cc:215: fprintf(stderr, "Error Accept: %s\n",
strerror(errno));
Mads says this should be removed.

https://chromiumcodereview.appspot.com/9837060/diff/1/runtime/bin/socket_maco...
File runtime/bin/socket_macos.cc (right):

https://chromiumcodereview.appspot.com/9837060/diff/1/runtime/bin/socket_maco...
runtime/bin/socket_macos.cc:206: fprintf(stderr, "Error Accept: %s\n",
strerror(errno));
ditto.

Expand Messages | Collapse Messages