Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 9837041: Revert arguments access support for inlined functions (r11109,r11118). (Closed)

Created:
8 years, 9 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Revert arguments access support for inlined functions (r11109,r11118). We are inserting HPushArgument instructions after HEnterInlined based on the environment at the point of the first arguments access. Which might create use before def if there are redundant phis in the environment. Committed: https://code.google.com/p/v8/source/detail?r=11128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -429 lines) Patch
M src/arm/lithium-arm.h View 3 chunks +2 lines, -22 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +2 lines, -17 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M src/hydrogen.h View 5 chunks +2 lines, -19 lines 0 comments Download
M src/hydrogen.cc View 13 chunks +41 lines, -93 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +3 lines, -23 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +16 lines, -25 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +2 lines, -22 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +2 lines, -16 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M src/mips/lithium-mips.h View 3 chunks +2 lines, -22 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +2 lines, -17 lines 0 comments Download
M src/runtime.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +15 lines, -24 lines 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +2 lines, -22 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +2 lines, -17 lines 0 comments Download
M test/mjsunit/compiler/inline-arguments.js View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 9 months ago (2012-03-23 15:33:12 UTC) #1
danno
8 years, 9 months ago (2012-03-23 15:33:59 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698