Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 9837018: Modify gpu::gles2::FeatureInfo::AddFeatures to enable feature flags based on requested features but… (Closed)

Created:
8 years, 9 months ago by bsalomon
Modified:
8 years, 9 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Modify gpu::gles2::FeatureInfo::AddFeatures to enable feature flags based on requested features but not disable them. BUG=112165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gpu/command_buffer/service/feature_info.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
PTAL
8 years, 9 months ago (2012-03-22 20:58:20 UTC) #1
greggman
On 2012/03/22 20:58:20, bsalomon wrote: > PTAL LGTM
8 years, 9 months ago (2012-03-22 21:02:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsalomon@google.com/9837018/1
8 years, 9 months ago (2012-03-23 00:34:56 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-23 02:26:58 UTC) #4
Try job failure for 9837018-1 (retry) on win_rel for step "ui_tests" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698