Issue 9837003: ash: Make sure the avatar is always of the fixed size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9837003: ash: Make sure the avatar is always of the fixed size. (Closed)

Created:
8 years, 9 months ago by sadrul

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Make sure the avatar is always of the fixed size. BUG=119450 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128212

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ash/system/user/tray_user.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 9 months ago (2012-03-22 14:56:01 UTC) #2

LGTM

On Thu, Mar 22, 2012 at 4:37 AM, <sadrul@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> ash: Make sure the avatar is always of the fixed size.
>
> BUG=119450
> TEST=none
>
>
> Please review this at
http://codereview.chromium.**org/9837003/<http://codereview.chromium.org/9837...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ash/system/user/tray_user.cc
>
>
> Index: ash/system/user/tray_user.cc
> diff --git a/ash/system/user/tray_user.cc b/ash/system/user/tray_user.cc
> index 892dfd02a5cbb3182430b262fb072a**e998fba8a2..**
> bf4659df1178918bd64499db848d4b**14e9f3392d 100644
> --- a/ash/system/user/tray_user.cc
> +++ b/ash/system/user/tray_user.cc
> @@ -378,6 +378,7 @@ void TrayUser::OnUpdateRecommended(**) {
>  void TrayUser::OnUserUpdate() {
>   avatar_->SetImage(
>       ash::Shell::GetInstance()->**tray_delegate()->GetUserImage(**));
> +  avatar_->SetImageSize(gfx::**Size(kUserIconSize, kUserIconSize));
>  }
>
>  }  // namespace internal
>
>
>

Expand Messages | Collapse Messages