Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9836127: Content shell: Javascript dialogs, first pass, just Mac for now. (Closed)

Created:
8 years, 9 months ago by Avi (use Gerrit)
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Content shell: Javascript dialogs, first pass, just Mac for now. BUG=120155 TEST=javascript dialogs work on the Mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129537

Patch Set 1 #

Total comments: 4

Patch Set 2 : rename files #

Patch Set 3 : ifdef out for non-mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/js_modal_dialog_cocoa.mm View 4 chunks +4 lines, -8 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/shell/shell.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
A content/shell/shell_javascript_dialog.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
A content/shell/shell_javascript_dialog_creator.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A content/shell/shell_javascript_dialog_creator.cc View 1 2 1 chunk +103 lines, -0 lines 0 comments Download
A content/shell/shell_javascript_dialog_mac.mm View 1 1 chunk +140 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
Jochen: You had the concerns on the bug and can review for the Mac, so ...
8 years, 9 months ago (2012-03-27 19:36:15 UTC) #1
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/9836127/diff/1/content/shell/shell_js_dialog.h File content/shell/shell_js_dialog.h (right): https://chromiumcodereview.appspot.com/9836127/diff/1/content/shell/shell_js_dialog.h#newcode5 content/shell/shell_js_dialog.h:5: #ifndef CONTENT_SHELL_SHELL_JS_DIALOG_H_ I think I would prefer shell_javascript_dialog instead ...
8 years, 9 months ago (2012-03-28 18:38:18 UTC) #2
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/9836127/diff/1/content/shell/shell_js_dialog.h File content/shell/shell_js_dialog.h (right): https://chromiumcodereview.appspot.com/9836127/diff/1/content/shell/shell_js_dialog.h#newcode5 content/shell/shell_js_dialog.h:5: #ifndef CONTENT_SHELL_SHELL_JS_DIALOG_H_ On 2012/03/28 18:38:18, jochen wrote: > I ...
8 years, 9 months ago (2012-03-28 20:43:43 UTC) #3
plz use chromium.org account
On 2012/03/28 20:43:43, Avi wrote: https://chromiumcodereview.appspot.com/9836127/diff/1/content/shell/shell_js_dialog.h#newcode33 > content/shell/shell_js_dialog.h:33: ~ShellJavaScriptDialog(); > On 2012/03/28 18:38:18, jochen wrote: ...
8 years, 9 months ago (2012-03-28 20:58:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9836127/5001
8 years, 9 months ago (2012-03-28 21:18:10 UTC) #5
commit-bot: I haz the power
Try job failure for 9836127-5001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-28 21:50:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9836127/15001
8 years, 9 months ago (2012-03-28 22:12:17 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-29 00:36:11 UTC) #8 
Change committed as 129537

Powered by Google App Engine
This is Rietveld 408576698