Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 9836097: Fortgot the changes as requested by Regis. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
===================================================================
--- runtime/vm/intrinsifier_ia32.cc (revision 5858)
+++ runtime/vm/intrinsifier_ia32.cc (working copy)
@@ -220,7 +220,7 @@
Library::Handle(Library::CoreImplLibrary()).LookupClass(class_name));
ASSERT(!cls.IsNull());
ASSERT(cls.HasTypeArguments());
- ASSERT(cls.NumTypeParameters() == 1);
+ ASSERT(cls.NumTypeArguments() == 1);
const intptr_t field_offset = cls.type_arguments_instance_field_offset();
ASSERT(field_offset != Class::kNoTypeArguments);
return field_offset;
@@ -238,7 +238,7 @@
const Immediate raw_null =
Immediate(reinterpret_cast<intptr_t>(Object::null()));
Label checked_ok;
- __ movl(EAX, Address(ESP, + 1 * kWordSize));
+ __ movl(EAX, Address(ESP, + 1 * kWordSize)); // Value.
__ cmpl(EAX, raw_null);
__ j(EQUAL, &checked_ok, Assembler::kNearJump);
__ testl(EAX, Immediate(kSmiTagMask));
@@ -262,7 +262,6 @@
__ j(EQUAL, &checked_ok, Assembler::kNearJump);
__ CompareObject(EAX, Type::ZoneHandle(Type::NumberInterface()));
__ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);
- // TODO(srdjan): Check classes.
__ Bind(&checked_ok);
}
__ movl(EBX, Address(ESP, + 2 * kWordSize)); // Index.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698