Sync promo: Only show skip button on startup

chrome/browser/resources/sync_promo/sync_promo.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(sail): Refactor options_page and remove this include.
 <include src="../options/options_page.js"/>
 <include src="../sync_setup_overlay.js"/>

[Dan Beam, 2012/03/26 22:09:00]

can you put

<script src="chrome://resources/js/util.js"></script>

in sync_promo.html above the include of this script so parseQueryParams() isn't
included transitively?

[sail, 2012/03/26 22:34:44]

Done.

 
 cr.define('sync_promo', function() {
   /**
    * SyncPromo class
    * Subclass of options.SyncSetupOverlay that customizes the sync setup
    * overlay for use in the new tab page.
    * @class
    */
   function SyncPromo() {
     options.SyncSetupOverlay.call(this, 'syncSetup',
@@ skipping 107 matching lines @@
         advancedOptionsClickedAlready = true;
       });
 
       // Re-used across both cancel buttons after a successful sign in.
       var cancelFunc = function() {
         chrome.send('SyncPromo:UserFlowAction',
                     [actions.CANCELLED_AFTER_SIGN_IN]);
       };
       $('confirm-everything-cancel').addEventListener('click', cancelFunc);
       $('choose-datatypes-cancel').addEventListener('click', cancelFunc);
+
+      // Add the source parameter to the document so that it can be used to
+      // selectively show and hide elements using CSS.
+      var params = parseQueryParams(document.location);
+      if (params.source != '0')
+        document.documentElement.setAttribute('promoNotStartup', true);

[Dan Beam, 2012/03/26 22:09:00]

nit: I think we tend to use all lower case because it's pretty unclear in the
CSS 2.1 spec whether case matters
(http://www.w3.org/TR/CSS2/selector.html#matching-attrs), but this is more
readable, so up to you.

[sail, 2012/03/26 22:34:44]

Done.

     },
 
     /**
      * Called when the page is unloading to record number of times a user tried
      * to sign in and if they left while a throbber was running.
      * @private
      */
     recordPageViewActions_: function() {
       chrome.send('SyncPromo:RecordSignInAttempts', [this.signInAttempts_]);
       if (this.throbberStart_)
@@ skipping 79 matching lines @@
   return {
     SyncPromo: SyncPromo
   };
 });
 
 var OptionsPage = options.OptionsPage;
 var SyncSetupOverlay = sync_promo.SyncPromo;
 window.addEventListener('DOMContentLoaded', sync_promo.SyncPromo.initialize);
 window.addEventListener('beforeunload',
     sync_promo.SyncPromo.recordPageViewActions.bind(sync_promo.SyncPromo));