Issue 9836091: Reset function info counters after context disposal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9836091: Reset function info counters after context disposal. (Closed)

Created:
8 years, 9 months ago by ulan

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reset function info counters after context disposal. R=jkummerow@chromium.org BUG=117767, V8:1902 Committed: https://code.google.com/p/v8/source/detail?r=11143

Patch Set 1 #

Patch Set 2 : Refactor #

Total comments: 1

Patch Set 3 : Address comment #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -12 lines)			Patch
M	src/compiler.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/factory.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mark-compact.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1	8 chunks	+22 lines, -10 lines	0 comments	Download
M	src/objects.cc	View	1 2	2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View		3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-26 08:52:42 UTC) #1

LGTM with a nit.

https://chromiumcodereview.appspot.com/9836091/diff/2001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/9836091/diff/2001/src/objects.cc#newco...
src/objects.cc:8135: if (target->is_inline_cache_stub()) {
nit: indentation

Expand Messages | Collapse Messages