Issue 9836066: Have content cancel requests for ResourceContexts when they shutdown, instead of depending on the e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9836066: Have content cancel requests for ResourceContexts when they shutdown, instead of depending on the e… (Closed)

Created:
8 years, 9 months ago by jam

Modified:
8 years, 9 months ago

Reviewers:
Jói

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Have content cancel requests for ResourceContexts when they shutdown, instead of depending on the embedder to do this. I ran into DCHECKs in tests that were running as browser_tests but should have been running as unittests instead. I made them unittests which should also make them faster and remove the flakiness. BUG=98716, 115188, 115150, 115307 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128909

Patch Set 1 : #

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -302 lines)			Patch
M	chrome/browser/profiles/profile_io_data.cc	View		3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	content/browser/in_process_webkit/dom_storage_browsertest.cc	View	1	1 chunk	+0 lines, -108 lines	0 comments	Download
M	content/browser/in_process_webkit/dom_storage_unittest.cc	View	1	5 chunks	+48 lines, -1 line	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_browsertest.cc	View	1	1 chunk	+0 lines, -173 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_context_impl.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
A	content/browser/in_process_webkit/indexed_db_unittest.cc	View	1	1 chunk	+178 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_impl.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/resource_dispatcher_host_unittest.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/resource_context_impl.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/browser/resource_context.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/resource_dispatcher_host.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

thank you for fixing up these tests

Expand Messages | Collapse Messages