Add reporting notification to the enterprise banner on the CrOS login screen.

Add reporting notification to the enterprise banner on the CrOS login screen.
    
This is only shown if there are any reporting features enabled via device policy. A help link takes the user to a helpapp article that explains more about reporting. With this CL, the helpapp link is actually stale, the helpapp change is pending though.
    
BUG=chromium-os:26625
TEST=Flip reporting policy switches, observe that the enterprise notification indicates reporting is enabled.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128957

[Mattias Nissler (ping if slow), 2012-03-23 15:44:25]

Patrick, here's my current state (includes two changes to hack the helpapp into
live on non-official builds).

It's currently not showing the banner if no reporting flag is enabled, which is
likely due to the handler being called to early when the webui is not yet fully
up.

[Patrick Dubroy, 2012-03-26 08:28:20]

Looks good, just a few small comments.

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/login/version_info_updater.cc:169: if
(cros_settings_->GetBoolean(kReportingFlags[i], &enabled))
Why not just "="? Using bitwise OR on a boolean seems a little funny. Also,
might as well break as soon as one flag is found to be true.

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe.css:766: #notification-area
.butter-bar {
Looks like this section got duplicated somehow.

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe.html (right):

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe.html:51: <div
id="notification-area">
Maybe we should separate this into butter_bar.html and include it from here and
login.html.

[Mattias Nissler (ping if slow), 2012-03-26 13:08:26]

Hey Patrick, can you take another look?

Nikita: OWNERS review.

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/login/version_info_updater.cc (right):

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/login/version_info_updater.cc:169: if
(cros_settings_->GetBoolean(kReportingFlags[i], &enabled))
On 2012/03/26 08:28:20, dubroy wrote:
> Why not just "="? Using bitwise OR on a boolean seems a little funny. Also,
> might as well break as soon as one flag is found to be true. 

Done.

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe.css:766: #notification-area
.butter-bar {
On 2012/03/26 08:28:20, dubroy wrote:
> Looks like this section got duplicated somehow.

Done.

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe.html (right):

https://chromiumcodereview.appspot.com/9836039/diff/1/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe.html:51: <div
id="notification-area">
On 2012/03/26 08:28:20, dubroy wrote:
> Maybe we should separate this into butter_bar.html and include it from here
and
> login.html.

Split out into notification_area.html

[Patrick Dubroy, 2012-03-26 13:25:16]

LGTM.

https://chromiumcodereview.appspot.com/9836039/diff/5003/chrome/browser/resou...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://chromiumcodereview.appspot.com/9836039/diff/5003/chrome/browser/resou...
chrome/browser/resources/chromeos/login/oobe.css:768: max-width: 850px;
What's actually changed here now?

[Mattias Nissler (ping if slow), 2012-03-26 13:27:15]

https://chromiumcodereview.appspot.com/9836039/diff/5003/chrome/browser/resou...
File chrome/browser/resources/chromeos/login/oobe.css (right):

https://chromiumcodereview.appspot.com/9836039/diff/5003/chrome/browser/resou...
chrome/browser/resources/chromeos/login/oobe.css:768: max-width: 850px;
On 2012/03/26 13:25:16, dubroy wrote:
> What's actually changed here now?

The file was missing a newline on the last line.

[Nikita (slow), 2012-03-26 14:06:08]

lgtm

https://chromiumcodereview.appspot.com/9836039/diff/5003/chrome/browser/resou...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

https://chromiumcodereview.appspot.com/9836039/diff/5003/chrome/browser/resou...
chrome/browser/resources/chromeos/login/display_manager.js:418:
chrome.send('launchHelpApp', [2535613]);
2535613 > constant

[commit-bot: I haz the power, 2012-03-26 14:38:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/9836039/6016

[commit-bot: I haz the power, 2012-03-26 17:43:46]

Try job failure for 9836039-6016 (retry) on win_rel for steps "ui_tests,
browser_tests".
It's a second try, previously, steps "ui_tests, browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-26 17:45:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/9836039/6016