Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8685)

Unified Diff: chrome_frame/chrome_frame_automation.cc

Issue 9836037: Adding policy support to Chrome Frame's launcher so that additional parameters can be passed to Chr… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/chrome_frame_automation.cc
diff --git a/chrome_frame/chrome_frame_automation.cc b/chrome_frame/chrome_frame_automation.cc
index b4d302300e173ac3eac986f366b014c1a89ed6b6..974840c5f0da3851ed31e512019f89585f23c721 100644
--- a/chrome_frame/chrome_frame_automation.cc
+++ b/chrome_frame/chrome_frame_automation.cc
@@ -519,7 +519,12 @@ bool ProxyFactory::ReleaseAutomationServer(void* server_id,
Vector::ContainerType::iterator it = std::find(proxies_.container().begin(),
proxies_.container().end(),
entry);
- proxies_.container().erase(it);
+ DLOG_IF(ERROR, it == proxies_.container().end())
grt (UTC plus 2) 2012/03/23 15:49:12 nit: make this DLOG(ERROR) and move it into an els
tommi (sloooow) - chröme 2012/03/26 11:24:37 Done.
+ << "Proxy wasn't found. Proxy map is likely empty (size="
+ << proxies_.container().size() << ").";
+ if (it != proxies_.container().end())
+ proxies_.container().erase(it);
+
lock_.Release();
}

Powered by Google App Engine
This is Rietveld 408576698