Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 9836018: Revert 104848 - [chromium] Re-enable Skia feColorMatrix filter implementation. (Closed)

Created:
8 years, 9 months ago by karen
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Revert 104848 - [chromium] Re-enable Skia feColorMatrix filter implementation. https://bugs.webkit.org/show_bug.cgi?id=76186 Source/WebCore: This code was landed in http://trac.webkit.org/changeset/104566 and partially reverted in http://trac.webkit.org/changeset/104632 due to problems with the Windows Shared builder. Those problems have been fixed in r3006, since rolled into Chrome. Reviewed by Kenneth Russell. Covered by SVG feColorMatrix tests. * WebCore.gypi: * platform/graphics/filters/FEColorMatrix.h: LayoutTests: Remove suppressions for tests which now pass. Reviewed by Kenneth Russell. * platform/chromium/test_expectations.txt: TBR=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=111758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M LayoutTests/platform/chromium/test_expectations.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/WebCore/WebCore.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/filters/FEColorMatrix.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
8 years, 9 months ago (2012-03-22 20:58:06 UTC) #1
senorblanco
8 years, 9 months ago (2012-03-22 21:00:53 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698