Issue 9836013: Choosing a default remote for determining base_url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9836013: Choosing a default remote for determining base_url. (Closed)

Created:
8 years, 9 months ago by jmbaker1

Modified:
8 years, 9 months ago

Reviewers:
Marc-Antoine Ruel (Google), Evan Martin, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Choosing a default remote for determining base_url. BUG=116057 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128293

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	git_cl.py	View	1	3 chunks	+27 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with line 406 removed. https://chromiumcodereview.appspot.com/9836013/diff/1/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/9836013/diff/1/git_cl.py#newcode406 git_cl.py:406: warn_default() Actually, I'd prefer ...

8 years, 9 months ago (2012-03-22 19:39:00 UTC) #2

jmbaker1

https://chromiumcodereview.appspot.com/9836013/diff/1/git_cl.py File git_cl.py (right): https://chromiumcodereview.appspot.com/9836013/diff/1/git_cl.py#newcode406 git_cl.py:406: warn_default() On 2012/03/22 19:39:00, Marc-Antoine Ruel wrote: > Actually, ...

8 years, 9 months ago (2012-03-22 19:56:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmbaker@chromium.org/9836013/2002

8 years, 9 months ago (2012-03-22 20:33:54 UTC) #4

Change committed as 128293

Expand Messages | Collapse Messages

Issue 9836013: Choosing a default remote for determining base_url. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages