Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 9836001: Fix Android build following r128172 (Closed)

Created:
8 years, 9 months ago by Ryan Sleevi
Modified:
8 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix Android build following r128172 BUG=114343 TEST=goes green TBR=wtc Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128174

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/base/cert_verify_proc_openssl.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
TBR wtc. jnd as FYI in case this breaks anything while syncing.
8 years, 9 months ago (2012-03-22 07:51:12 UTC) #1
wtc
http://codereview.chromium.org/9836001/diff/1/net/base/cert_verify_proc_openssl.cc File net/base/cert_verify_proc_openssl.cc (right): http://codereview.chromium.org/9836001/diff/1/net/base/cert_verify_proc_openssl.cc#newcode232 net/base/cert_verify_proc_openssl.cc:232: GetChainDEREncodedBytes(cert, &cert_bytes); Should this be cert->GetChainDEREncodedBytes(&cert_bytes); ?
8 years, 9 months ago (2012-03-22 17:43:13 UTC) #2
Ryan Sleevi
On 2012/03/22 17:43:13, wtc wrote: > http://codereview.chromium.org/9836001/diff/1/net/base/cert_verify_proc_openssl.cc > File net/base/cert_verify_proc_openssl.cc (right): > > http://codereview.chromium.org/9836001/diff/1/net/base/cert_verify_proc_openssl.cc#newcode232 > ...
8 years, 9 months ago (2012-03-22 17:45:58 UTC) #3
wtc
8 years, 9 months ago (2012-03-22 17:46:53 UTC) #4
Thank you.  LGTM.

Powered by Google App Engine
This is Rietveld 408576698