Issue 9835084: Implementing stateful directory tracking for dtrace on OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9835084: Implementing stateful directory tracking for dtrace on OSX. (Closed)

Created:
8 years, 9 months ago by M-A Ruel

Modified:
8 years, 8 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, pam+watch_chromium.org, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implementing stateful directory tracking for dtrace on OSX. Includes custom children process tracking and manual cwd tracking. R=rogerta@chromium.org BUG=98834 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129433

Patch Set 1 #

Patch Set 2 : Remove dead code #

Patch Set 3 : . #

Patch Set 4 : Improve logging by reducing its verbosity #

Patch Set 5 : rebase against http://codereview.chromium.org/9834052 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -151 lines)			Patch
M	tools/isolate/isolate_test.py	View	1 2 3	1 chunk	+7 lines, -16 lines	0 comments	Download
M	tools/isolate/trace_inputs.py	View	1 2 3 4	3 chunks	+268 lines, -88 lines	0 comments	Download
M	tools/isolate/trace_inputs_test.py	View	1 2 3 4	3 chunks	+7 lines, -47 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Finally (!) This will greatly help with the next unit tests since I now have ...

8 years, 9 months ago (2012-03-24 15:50:43 UTC) #1

M-A Ruel

Dependent on http://codereview.chromium.org/9834052. This removes the test cases that were checking for wrong behavior on ...

8 years, 9 months ago (2012-03-24 15:52:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9835084/8003

8 years, 8 months ago (2012-03-28 14:15:15 UTC) #4

commit-bot: I haz the power

8 years, 8 months ago (2012-03-28 17:06:43 UTC) #5

Try job failure for 9835084-8003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages