Issue 9835048: Allow a patch file to be specified to merge-to-branch.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9835048: Allow a patch file to be specified to merge-to-branch.sh (Closed)

Created:
8 years, 9 months ago by danno

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Allow a patch file to be specified to merge-to-branch.sh R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11119

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 2

Patch Set 3 : review feedback #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -5 lines)			Patch
	M	tools/merge-to-branch.sh	View	1 2	7 chunks	+29 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-23 11:48:41 UTC) #2

LGTM with comments.

http://codereview.chromium.org/9835048/diff/2001/tools/merge-to-branch.sh
File tools/merge-to-branch.sh (right):

http://codereview.chromium.org/9835048/diff/2001/tools/merge-to-branch.sh#new...
tools/merge-to-branch.sh:71: while getopts "hs:fp:" OPTION ; do
as discussed offline, we still want the leading ":".

http://codereview.chromium.org/9835048/diff/2001/tools/merge-to-branch.sh#new...
tools/merge-to-branch.sh:266: echo "patches:$REVISION_LIST"
nit:
[[ -n "$REVISION_LIST" ]] && echo "patches:$REVISION_LIST"

Expand Messages | Collapse Messages