chrome/renderer/native_handler.h - Issue 9835039: Make app_custom_bindings.js lazily evaluated so it doesn't execute on every page load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/native_handler.h

Issue 9835039: Make app_custom_bindings.js lazily evaluated so it doesn't execute on every page load. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: respond to comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/native_handler.h

diff --git a/chrome/renderer/native_handler.h b/chrome/renderer/native_handler.h

index f595a0de0be09586213e267106d6c63bd93c8a4f..6efe444b79a85be7dd75acbb14ffc700815336b6 100644

--- a/chrome/renderer/native_handler.h

+++ b/chrome/renderer/native_handler.h

@@ -49,7 +49,7 @@ class NativeHandler {

static v8::Handle<v8::Value> Router(const v8::Arguments& args);

std::vector<linked_ptr<HandlerFunction> > handler_functions_;

- v8::Handle<v8::ObjectTemplate> object_template_;

+ v8::Persistent<v8::ObjectTemplate> object_template_;

DISALLOW_COPY_AND_ASSIGN(NativeHandler);

};

« chrome/renderer/module_system_unittest.cc ('K') | « chrome/renderer/module_system_unittest.cc ('k') | chrome/renderer/native_handler.cc » ('j') | no next file with comments »