Make app_custom_bindings.js lazily evaluated so it doesn't execute on every page load.

chrome/renderer/module_system_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_piece.h"
 #include "chrome/renderer/module_system.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 163 matching lines @@
   v8::Handle<v8::Object> object = v8::Object::New();
   v8::Context::GetCurrent()->Global()->Set(v8::String::New("object"), object);
 
   module_system_->SetLazyField(object, "blah", "lazy", "x");
 
   RegisterModule("test",
       "var assert = requireNative('assert');"
       "assert.AssertTrue(object.blah == 5);");
   module_system_->Require("test");
 }
+
+TEST_F(ModuleSystemTest, TestLazyFieldYieldingObject) {
+  RegisterModule("lazy",
+      "var object = {};"
+      "object.__defineGetter__('z', function() { return 1; });"
+      "object.x = 5;"
+      "object.y = 10;"
+      "exports.object = object;");
+
+  v8::Handle<v8::Object> object = v8::Object::New();
+  v8::Context::GetCurrent()->Global()->Set(v8::String::New("object"), object);
+
+  module_system_->SetLazyField(object, "thing", "lazy", "object");
+
+  RegisterModule("test",
+      "var assert = requireNative('assert');"
+      "assert.AssertTrue(object.thing.x == 5);"

[not at google - send to devlin, 2012/03/25 22:42:58]

Once again, could you have a global "count" and check that it's undefined before
evaluating object.thing, and 1 thereafter?

[koz (OOO until 15th September), 2012/03/26 01:36:09]

Done in a separate test.

+      "assert.AssertTrue(object.thing.y == 10);"

[not at google - send to devlin, 2012/03/25 22:42:58]

I don't see the advantage in having x and y be both integers. Perhaps to mix
things up make y a function that returns 10?

[koz (OOO until 15th September), 2012/03/26 01:36:09]

Done.

+      "assert.AssertTrue(object.thing.z == 1);"
+      );
+  module_system_->Require("test");
+}
+
+TEST_F(ModuleSystemTest, TestTransitiveRequire) {
+  RegisterModule("dependency",
+      "exports.x = 5;");
+  RegisterModule("lazy",
+      "exports.output = require('dependency');");
+
+  v8::Handle<v8::Object> object = v8::Object::New();
+  v8::Context::GetCurrent()->Global()->Set(v8::String::New("object"), object);
+
+  module_system_->SetLazyField(object, "thing", "lazy", "output");
+
+  RegisterModule("test",
+      "var assert = requireNative('assert');"
+      "assert.AssertTrue(object.thing.x == 5);");

[not at google - send to devlin, 2012/03/25 22:42:58]

If this was instead

var x = object.thing.x;
var assert = requireNative('assert');
assert.AssertTrue(x == 5);

would that trigger the possibly-a-bug that I mentioned earlier?

[koz (OOO until 15th September), 2012/03/26 01:36:09]

Yeah, it would if you wrap it in a NativesEnabledScope. I'll add that as a
separate test.

+  module_system_->Require("test");
+}