Add roleDescription to DumpAccessibilityTree for mac.

Add roleDescription to DumpAccessibilityTree for mac.


BUG=
TEST=Rebaselined test expectations for DumpAccessibilityTreeTest tests.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131719

[aboxhall, 2012-03-27 00:26:37]

https://chromiumcodereview.appspot.com/9838042/ depends on this change.

[dmazzoni, 2012-03-27 02:15:25]

lgtm

[David Tseng, 2012-03-27 16:38:38]

lgtm

On 3/26/12, dmazzoni@chromium.org <dmazzoni@chromium.org> wrote:
> lgtm
>
>
>
> https://chromiumcodereview.appspot.com/9835038/
>

[commit-bot: I haz the power, 2012-03-28 02:38:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9835038/1

[commit-bot: I haz the power, 2012-03-28 02:38:11]

Presubmit check for 9835038-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content

[aboxhall, 2012-03-28 02:54:39]

I don't understand what the problem is here;
http://codereview.chromium.org/9639016 and
https://chromiumcodereview.appspot.com/9617019 seemed to go in without
content/OWNERS approval. What have I done wrong?

[dmazzoni, 2012-03-28 15:14:19]

No idea. You could do a git cl dcommit to commit directly, that
doesn't seem unreasonable.

But either way, please do a try run. The accessibility tests aren't
run by the commit queue, so you should always run git try when
touching accessibility code just to make sure things behave the same
on the bots as they do on your local machine.

Could you add an OWNERS file to content/test/data/accessibility as a
separate CL?

- Dominic

On Tue, Mar 27, 2012 at 7:54 PM,  <aboxhall@chromium.org> wrote:
> I don't understand what the problem is here;
> http://codereview.chromium.org/9639016 and
> https://chromiumcodereview.appspot.com/9617019 seemed to go in without
> content/OWNERS approval. What have I done wrong?
>
> http://codereview.chromium.org/9835038/

[commit-bot: I haz the power, 2012-03-29 05:15:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9835038/1

[commit-bot: I haz the power, 2012-03-29 08:16:40]

Try job failure for 9835038-1 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[dmazzoni, 2012-04-04 20:02:02]

Alice is out, should we try to cq this again?

[David Tseng, 2012-04-04 23:59:10]

Sure; this probably will conflict with Aaron's patch though.

On 4/4/12, dmazzoni@chromium.org <dmazzoni@chromium.org> wrote:
> Alice is out, should we try to cq this again?
>
> http://codereview.chromium.org/9835038/
>

[commit-bot: I haz the power, 2012-04-11 00:28:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9835038/21001

[aboxhall, 2012-04-11 01:38:19]

I just tried to run this test locally and one of the tests failed, but when I
regenerated the test expectations they were identical to the original ones. Not
sure what's going on there, so I'm going to see what happens with a try.

[commit-bot: I haz the power, 2012-04-11 03:53:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9835038/21001

[commit-bot: I haz the power, 2012-04-11 05:44:41]

Change committed as 131719