Save the wallpaper selected for the user if was not set previsouly (first time).

Save the wallpaper selected for the user if was not set previsouly (first time).


BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128663

[Emmanuel Saint-loubert-Bié, 2012-03-24 01:18:18]

As discussed

[Emmanuel Saint-loubert-Bié, 2012-03-24 01:26:45]

Ben,

PTAL. Thanks

-- Emmanuel

[Ben Goodger (Google), 2012-03-24 01:28:17]

LGTM

On Fri, Mar 23, 2012 at 6:18 PM, <saintlou@chromium.org> wrote:

> Reviewers: bshe,
>
> Message:
>
> As discussed
>
> Description:
> Save the wallpaper selected for the user if was not set previsouly (first
> time).
>
>
> BUG=none
> TEST=none
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/9834077/<https://chromiumcodereview....
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/chromeos/login/**user_manager_impl.cc
>
>
> Index: chrome/browser/chromeos/login/**user_manager_impl.cc
> diff --git a/chrome/browser/chromeos/**login/user_manager_impl.cc
> b/chrome/browser/chromeos/**login/user_manager_impl.cc
> index a5800a51771b635d33e3d4b982e0c2**b4a06f7acd..**
> bf365172e4923daf828df612989b3d**7d7283aebd 100644
> --- a/chrome/browser/chromeos/**login/user_manager_impl.cc
> +++ b/chrome/browser/chromeos/**login/user_manager_impl.cc
> @@ -914,8 +914,8 @@ int UserManagerImpl::**GetUserWallpaper(const
> std::string& username) {
>   const DictionaryValue* user_wallpapers =
>       local_state->GetDictionary(**UserManager::kUserWallpapers);
>   int index = ash::GetDefaultWallpaperIndex(**);
> -  user_wallpapers->**GetIntegerWithoutPathExpansion**(username,
> -                                                  &index);
> +  if (!user_wallpapers->**GetIntegerWithoutPathExpansion**(username,
> &index))
> +    SaveWallpaperDefaultIndex(**username, index);
>   return index;
>  }
>
>
>
>

[bshe, 2012-03-24 02:29:18]

On 2012/03/24 01:28:17, Ben Goodger (Google) wrote:
> LGTM
> 
> On Fri, Mar 23, 2012 at 6:18 PM, <mailto:saintlou@chromium.org> wrote:
> 
> > Reviewers: bshe,
> >
> > Message:
> >
> > As discussed
> >
> > Description:
> > Save the wallpaper selected for the user if was not set previsouly (first
> > time).
> >
> >
> > BUG=none
> > TEST=none
> >
> >
> > Please review this at
>
https://chromiumcodereview.**appspot.com/9834077/%3Chttps://chromiumcoderevie...>
> >
> > SVN Base:
>
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
> >
> > Affected files:
> >  M chrome/browser/chromeos/login/**user_manager_impl.cc
> >
> >
> > Index: chrome/browser/chromeos/login/**user_manager_impl.cc
> > diff --git a/chrome/browser/chromeos/**login/user_manager_impl.cc
> > b/chrome/browser/chromeos/**login/user_manager_impl.cc
> > index a5800a51771b635d33e3d4b982e0c2**b4a06f7acd..**
> > bf365172e4923daf828df612989b3d**7d7283aebd 100644
> > --- a/chrome/browser/chromeos/**login/user_manager_impl.cc
> > +++ b/chrome/browser/chromeos/**login/user_manager_impl.cc
> > @@ -914,8 +914,8 @@ int UserManagerImpl::**GetUserWallpaper(const
> > std::string& username) {
> >   const DictionaryValue* user_wallpapers =
> >       local_state->GetDictionary(**UserManager::kUserWallpapers);
> >   int index = ash::GetDefaultWallpaperIndex(**);
> > -  user_wallpapers->**GetIntegerWithoutPathExpansion**(username,
> > -                                                  &index);
> > +  if (!user_wallpapers->**GetIntegerWithoutPathExpansion**(username,
> > &index))
> > +    SaveWallpaperDefaultIndex(**username, index);
> >   return index;
> >  }
> >
> >
> >
> >

lgtm