Moved WebDataService to ProfileKeyedService

chrome/browser/password_manager/password_store_default.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_DEFAULT_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_DEFAULT_H_
 #pragma once
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/password_manager/login_database.h"
 #include "chrome/browser/password_manager/password_store.h"
+#include "chrome/browser/webdata/web_data_service.h"

[Ilya Sherman, 2012/03/27 01:01:17]

nit: Why does this now need to be a #include rather than a forward-declaration?

[GeorgeY, 2012/03/30 19:20:12]

Line 52. Otherwise it needs to be included every time prior to this include.

[Ilya Sherman, 2012/03/30 20:50:05]

Huh, a scoped_refptr<Foo> needs more than a forward-declaration for Foo?  That
seems surprising to me, but o.k.

[Peter Kasting, 2012/03/30 20:53:53]

No, we shouldn't need a #include to do scoped_ptr<Foo> as long as that object is
not actually used by e.g. an inline function definition.

Rather, password_store_default.cc as well as any subclass implementations should
#include the header.

Other files that just #include this file will not need to also #include
web_data_service.h; if they do it's for some other reason.

[GeorgeY, 2012/04/02 21:57:43]

There is a some non obvious usage in one of the header files, that
alphabetically precede "chrome/browser/webdata/web_data_service.h".
Unfortunately compiler does not tell at what moment it tried to expand template,
just that it failed to find AddRef/Release methods.

[Peter Kasting, 2012/04/02 22:09:05]

That doesn't justify making this change.  It just means we need to fix whatever
the other problem is.

Did you try running the patch, sans this change, through all the different
platforms to see if one of the compilers gives you more helpful error output?

[GeorgeY, 2012/04/02 22:49:02]

found and fixed

 
 class Profile;
-class WebDataService;
 
 // Simple password store implementation that delegates everything to
 // the LoginDatabase.
 class PasswordStoreDefault : public PasswordStore {
  public:
   // Takes ownership of |login_db|.
   PasswordStoreDefault(LoginDatabase* login_db,
                        Profile* profile,
                        WebDataService* web_data_service);
 
@@ skipping 36 matching lines @@
 
   scoped_ptr<LoginDatabase> login_db_;
   Profile* profile_;
 
   scoped_ptr<MigrateHelper> migrate_helper_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordStoreDefault);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_STORE_DEFAULT_H_