Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 9834048: Roll Skia DEPS to 3470 (Closed)

Created:
8 years, 9 months ago by epoger
Modified:
8 years, 9 months ago
Reviewers:
CC:
chromium-reviews, skia-dev_google.com, djsollen
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : include SkTypefaceCache.cpp in android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -32 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.cc View 3 chunks +12 lines, -17 lines 0 comments Download
M skia/skia.gyp View 1 6 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Re-attempting vandebo's DEPS roll from yesterday ( http://codereview.chromium.org/9792001/ ), now with android trybot. control group ...
8 years, 9 months ago (2012-03-23 13:39:28 UTC) #1
epoger
On 2012/03/23 13:39:28, epoger wrote: > presumably, though, we will see > errors in the ...
8 years, 9 months ago (2012-03-23 13:59:25 UTC) #2
epoger
Derek found a suspicious line in skia.gyp that was excluding SkTypefaceCache.cpp for android builds. Off ...
8 years, 9 months ago (2012-03-23 15:06:28 UTC) #3
vandebo (ex-Chrome)
LGTM - owner stamp for printing directory.
8 years, 9 months ago (2012-03-23 15:21:19 UTC) #4
epoger
On 2012/03/23 15:06:28, epoger wrote: > Derek found a suspicious line in skia.gyp that was ...
8 years, 9 months ago (2012-03-23 15:29:39 UTC) #5
epoger
8 years, 9 months ago (2012-03-23 17:46:56 UTC) #6
Trybot results look good.  I'm gonna go ahead and commit.


linux : green
linux_gpu : looks like this bot might be down, it didn't run the deps roll or
whitespace change
linux_chromeos : 1 new browser_test failure, looks like a flake
linux_layout : no new failures
linux_layout_rel : green
linux_shared : green

mac : green
mac_gpu : green
mac_layout : 1 new webkit_test failure, doesn't look Skia-related
mac_layout_rel : green

win : 202 failed browser_tests, but they don't look Skia-related, so I figure
they are due to trybot flakiness
win_gpu : green
win_layout : timed out in update step, usual trybot crumminess
win_layout_rel : green

android : green

Powered by Google App Engine
This is Rietveld 408576698