Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4669)

Unified Diff: chrome/browser/ui/webui/chrome_url_data_manager_backend.cc

Issue 9834039: Remove resource_request_info_impl.h dependency from chrome. This also makes blob/file system urls w… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chrome_url_data_manager_backend.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chrome_url_data_manager_backend.cc
===================================================================
--- chrome/browser/ui/webui/chrome_url_data_manager_backend.cc (revision 128327)
+++ chrome/browser/ui/webui/chrome_url_data_manager_backend.cc (working copy)
@@ -18,8 +18,6 @@
#include "base/path_service.h"
#include "base/string_util.h"
#include "chrome/browser/net/chrome_url_request_context.h"
-#include "chrome/browser/net/view_blob_internals_job_factory.h"
-#include "chrome/browser/net/view_http_cache_job_factory.h"
#include "chrome/browser/ui/webui/shared_resources_data_source.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
@@ -34,8 +32,6 @@
#include "net/url_request/url_request_file_job.h"
#include "net/url_request/url_request_job.h"
#include "net/url_request/url_request_job_factory.h"
-#include "webkit/appcache/appcache_service.h"
-#include "webkit/appcache/view_appcache_internals_job.h"
using content::BrowserThread;
@@ -319,18 +315,10 @@
namespace {
-bool IsViewAppCacheInternalsURL(const GURL& url) {
- return url.SchemeIs(chrome::kChromeUIScheme) &&
- url.host() == chrome::kChromeUIAppCacheInternalsHost;
-}
-
class ChromeProtocolHandler
: public net::URLRequestJobFactory::ProtocolHandler {
public:
- ChromeProtocolHandler(
- ChromeURLDataManagerBackend* backend,
- appcache::AppCacheService* appcache_service,
- webkit_blob::BlobStorageController* blob_storage_controller);
+ explicit ChromeProtocolHandler(ChromeURLDataManagerBackend* backend);
~ChromeProtocolHandler();
virtual net::URLRequestJob* MaybeCreateJob(
@@ -339,19 +327,13 @@
private:
// These members are owned by ProfileIOData, which owns this ProtocolHandler.
ChromeURLDataManagerBackend* const backend_;
- appcache::AppCacheService* const appcache_service_;
- webkit_blob::BlobStorageController* const blob_storage_controller_;
DISALLOW_COPY_AND_ASSIGN(ChromeProtocolHandler);
};
ChromeProtocolHandler::ChromeProtocolHandler(
- ChromeURLDataManagerBackend* backend,
- appcache::AppCacheService* appcache_service,
- webkit_blob::BlobStorageController* blob_storage_controller)
- : backend_(backend),
- appcache_service_(appcache_service),
- blob_storage_controller_(blob_storage_controller) {}
+ ChromeURLDataManagerBackend* backend)
+ : backend_(backend) {}
ChromeProtocolHandler::~ChromeProtocolHandler() {}
@@ -359,20 +341,6 @@
net::URLRequest* request) const {
DCHECK(request);
- // Next check for chrome://view-http-cache/*, which uses its own job type.
- if (ViewHttpCacheJobFactory::IsSupportedURL(request->url()))
- return ViewHttpCacheJobFactory::CreateJobForRequest(request);
-
- // Next check for chrome://appcache-internals/, which uses its own job type.
- if (IsViewAppCacheInternalsURL(request->url()))
- return appcache::ViewAppCacheInternalsJobFactory::CreateJobForRequest(
- request, appcache_service_);
-
- // Next check for chrome://blob-internals/, which uses its own job type.
- if (ViewBlobInternalsJobFactory::IsSupportedURL(request->url()))
- return ViewBlobInternalsJobFactory::CreateJobForRequest(
- request, blob_storage_controller_);
-
// Fall back to using a custom handler
return new URLRequestChromeJob(request, backend_);
}
@@ -395,14 +363,9 @@
// static
net::URLRequestJobFactory::ProtocolHandler*
ChromeURLDataManagerBackend::CreateProtocolHandler(
- ChromeURLDataManagerBackend* backend,
- appcache::AppCacheService* appcache_service,
- webkit_blob::BlobStorageController* blob_storage_controller) {
- DCHECK(appcache_service);
- DCHECK(blob_storage_controller);
+ ChromeURLDataManagerBackend* backend) {
DCHECK(backend);
- return new ChromeProtocolHandler(
- backend, appcache_service, blob_storage_controller);
+ return new ChromeProtocolHandler(backend);
}
void ChromeURLDataManagerBackend::AddDataSource(
« no previous file with comments | « chrome/browser/ui/webui/chrome_url_data_manager_backend.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698