Add error handling to the HTTP library

tests/standalone/src/io/HttpParserTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #source("../../../../runtime/bin/http_parser.dart");
 
 class HttpParserTest {
   static void runAllTests() {
     testParseRequest();
     testParseResponse();
+    testParseInvalidRequest();
+    testParseInvalidResponse();
   }
 
   static void _testParseRequest(String request,
                                 String expectedMethod,
                                 String expectedUri,
                                 [int expectedContentLength = -1,
                                  int expectedBytesReceived = 0,
                                  Map expectedHeaders = null,
                                  bool chunked = false]) {
     _HttpParser httpParser;
@@ skipping 61 matching lines @@
     }
 
     // Test parsing the request three times delivering the data in
     // different chunks.
     List<int> requestData = request.charCodes();
     testWrite(requestData);
     testWrite(requestData, 10);
     testWrite(requestData, 1);
   }
 
+  static void _testParseInvalidRequest(String request) {
+    _HttpParser httpParser;
+    bool errorCalled;
+
+    void reset() {
+      httpParser = new _HttpParser();
+      httpParser.responseStart = (s, r) { Expect.fail("Expected request"); };
+      httpParser.error = (e) {
+        errorCalled = true;
+      };
+
+      errorCalled = false;
+    }
+
+    void checkExpectations() {

[Mads Ager (google), 2012/03/22 14:30:08]

Not sure that this method adds much. Just inline?

[Søren Gjesse, 2012/03/23 07:34:20]

Done.

+      Expect.isTrue(errorCalled);
+    }
+
+    void testWrite(List<int> requestData, [int chunkSize = -1]) {
+      if (chunkSize == -1) chunkSize = requestData.length;
+      reset();
+      for (int pos = 0; pos < requestData.length; pos += chunkSize) {
+        int remaining = requestData.length - pos;
+        int writeLength = Math.min(chunkSize, remaining);
+        httpParser.writeList(requestData, pos, writeLength);
+      }
+      checkExpectations();
+    }
+
+    // Test parsing the request three times delivering the data in
+    // different chunks.
+    List<int> requestData = request.charCodes();
+    testWrite(requestData);
+    testWrite(requestData, 10);
+    testWrite(requestData, 1);
+  }
+
   static void _testParseResponse(String response,
                                  int expectedStatusCode,
                                  String expectedReasonPhrase,
                                  [int expectedContentLength = -1,
                                   int expectedBytesReceived = 0,
                                   Map expectedHeaders = null,
                                   bool chunked = false,
                                   bool close = false,
                                   String responseToMethod = null]) {
     _HttpParser httpParser;
@@ skipping 68 matching lines @@
     }
 
     // Test parsing the request three times delivering the data in
     // different chunks.
     List<int> responseData = response.charCodes();
     testWrite(responseData);
     testWrite(responseData, 10);
     testWrite(responseData, 1);
   }
 
+  static void _testParseInvalidResponse(String response, [bool close = false]) {
+    _HttpParser httpParser;
+    bool errorCalled;
+
+    void reset() {
+      httpParser = new _HttpParser();
+      httpParser.requestStart = (m, u) => Expect.fail("Expected response");
+      httpParser.error = (e) => errorCalled = true;
+
+      errorCalled = false;
+    }
+
+    void checkExpectations() {

[Mads Ager (google), 2012/03/22 14:30:08]

Ditto.

[Søren Gjesse, 2012/03/23 07:34:20]

Done.

+      Expect.isTrue(errorCalled);
+    }
+
+    void testWrite(List<int> requestData, [int chunkSize = -1]) {
+      if (chunkSize == -1) chunkSize = requestData.length;
+      reset();
+      for (int pos = 0; pos < requestData.length; pos += chunkSize) {
+        int remaining = requestData.length - pos;
+        int writeLength = Math.min(chunkSize, remaining);
+        httpParser.writeList(requestData, pos, writeLength);
+      }
+      if (close) httpParser.connectionClosed();
+      checkExpectations();
+    }
+
+    // Test parsing the request three times delivering the data in
+    // different chunks.
+    List<int> responseData = response.charCodes();
+    testWrite(responseData);
+    testWrite(responseData, 10);
+    testWrite(responseData, 1);
+  }
+
   static void testParseRequest() {
     String request;
     Map headers;
     request = "GET / HTTP/1.1\r\n\r\n";
     _testParseRequest(request, "GET", "/");
 
     request = "POST / HTTP/1.1\r\n\r\n";
     _testParseRequest(request, "POST", "/");
 
     request = "GET /index.html HTTP/1.1\r\n\r\n";
@@ skipping 240 matching lines @@
 0123456789012345678901234567890\r
 0\r\n\r\n""";
     _testParseResponse(response,
                        200,
                        "OK",
                        expectedContentLength: -1,
                        expectedBytesReceived: 57,
                        chunked: true);
 
     // Test HTTP response without any transfer length indications
-    // where closing the connections indicated end of body.
+    // where closing the connections indicates end of body.
     response = """
 HTTP/1.1 200 OK\r
 \r
 01234567890123456789012345
 0123456789012345678901234567890
 """;
   _testParseResponse(response,
                      200,
                      "OK",
                      expectedContentLength: -1,
                      expectedBytesReceived: 59,
                      close: true);
   }
+
+  static void testParseInvalidRequest() {
+    String request;
+    request = "GET /\r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    request = "GET / \r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    request = "/ HTTP/1.1\r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    request = "GET HTTP/1.1\r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    request = " / HTTP/1.1\r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    request = "@ / HTTP/1.1\r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    request = "GET / TTP/1.1\r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    request = "GET / HTTP/1.\r\n\r\n";
+    _testParseInvalidRequest(request);
+
+    // Currently no HTTP 1.0 support.
+    request = "GET / HTTP/1.0\r\n\r\n";
+    _testParseInvalidRequest(request);
+  }
+
+  static void testParseInvalidResponse() {
+    String response;
+
+    response = "HTTP/1.1\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 \r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 200\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 200 \r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 OK\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "200 OK\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1. 200 OK\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 200 O\rK\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 000 OK\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 999 Server Error\r\nContent-Length: 0\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = "HTTP/1.1 200 OK\r\nContent-Length: x\r\n\r\n";
+    _testParseInvalidResponse(response);
+
+    response = """
+HTTP/1.1 200 OK\r
+Transfer-Encoding: chunked\r
+\r
+1A\r
+01234567890123456789012345\r
+1g\r
+0123456789012345678901234567890\r
+0\r\n\r\n""";
+    _testParseInvalidResponse(response);
+  }
 }
 
 
 void main() {
   HttpParserTest.runAllTests();
 }