chromeos: Fix a crash when trying to open settings page when there is no browser window.

chromeos: Fix a crash when trying to open settings page when there is no browser window.

BUG=119400
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128185

[sadrul, 2012-03-22 00:05:10]

This is a workaround for the bug. We can probably P2 the bug itself after this.

[sky, 2012-03-22 00:40:09]

http://codereview.chromium.org/9829007/diff/1/chrome/browser/chromeos/system/...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

http://codereview.chromium.org/9829007/diff/1/chrome/browser/chromeos/system/...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:423: browser =
Browser::OpenEmptyWindow(profile->GetOriginalProfile());
I think this is the wrong thing when not signed in. I think you want
GetDefaultProfileOrOffTheRecord which sadly hasn't landed yet. It's at
http://codereview.chromium.org/9691032 .

[sadrul, 2012-03-22 00:46:40]

http://codereview.chromium.org/9829007/diff/1/chrome/browser/chromeos/system/...
File chrome/browser/chromeos/system/ash_system_tray_delegate.cc (right):

http://codereview.chromium.org/9829007/diff/1/chrome/browser/chromeos/system/...
chrome/browser/chromeos/system/ash_system_tray_delegate.cc:423: browser =
Browser::OpenEmptyWindow(profile->GetOriginalProfile());
On 2012/03/22 00:40:09, sky wrote:
> I think this is the wrong thing when not signed in. I think you want
> GetDefaultProfileOrOffTheRecord which sadly hasn't landed yet. It's at
> http://codereview.chromium.org/9691032 .

Ah, good point. I'll wait for that CL to land.

[sadrul, 2012-03-22 00:51:11]

I have gone ahead and made the change now.

[sadrul, 2012-03-22 03:17:13]

On 2012/03/22 00:51:11, sadrul wrote:
> I have gone ahead and made the change now.

The other CL has landed. Another look?

[sky, 2012-03-22 03:34:36]

LGTM