Issue 9829003: Add smooth scrolling command line switch for test_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9829003: Add smooth scrolling command line switch for test_shell. (Closed)

Created:
8 years, 9 months ago by Scott Byer

Modified:
8 years, 9 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add smooth scrolling command line switch for test_shell. This makes it easier to debug layout test cases involving scroll animation. BUG=118507 TEST=Bring up test shell with --enable-smooth-scrolling switch and scroll around, should be animated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128235

Patch Set 1 #

Patch Set 2 : Fix copyright date #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
M	webkit/tools/test_shell/test_shell.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Byer

This helped me get the scroll animation layout tests together.

8 years, 9 months ago (2012-03-22 00:33:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottbyer@chromium.org/9829003/7

8 years, 9 months ago (2012-03-22 17:05:58 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-22 17:06:02 UTC) #4

Presubmit check for 9829003-7 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  webkit/tools/test_shell/test_shell.h

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages