Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2612)

Unified Diff: content/renderer/media/webrtc_audio_device_impl.cc

Issue 9826023: Merge AudioRendererImpl and AudioRendererBase; add NullAudioSink (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase ToT + address CR comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_audio_device_impl.cc
diff --git a/content/renderer/media/webrtc_audio_device_impl.cc b/content/renderer/media/webrtc_audio_device_impl.cc
index 1eeea33b63d4eaa79ad8da1bd50cc7dd5ae79616..e2a96f18d999c927bb6dc951a1d2d1327ed59aa3 100644
--- a/content/renderer/media/webrtc_audio_device_impl.cc
+++ b/content/renderer/media/webrtc_audio_device_impl.cc
@@ -72,10 +72,10 @@ int32_t WebRtcAudioDeviceImpl::Release() {
return ret;
}
-size_t WebRtcAudioDeviceImpl::Render(
+int WebRtcAudioDeviceImpl::Render(
const std::vector<float*>& audio_data,
- size_t number_of_frames,
- size_t audio_delay_milliseconds) {
+ int number_of_frames,
+ int audio_delay_milliseconds) {
DCHECK_LE(number_of_frames, output_buffer_size());
{
@@ -92,12 +92,12 @@ size_t WebRtcAudioDeviceImpl::Render(
// Even if the hardware runs at 44.1kHz, we use 44.0 internally.
samples_per_sec = 44000;
}
- uint32_t samples_per_10_msec = (samples_per_sec / 100);
+ int samples_per_10_msec = (samples_per_sec / 100);
const int bytes_per_10_msec =
channels * samples_per_10_msec * bytes_per_sample_;
uint32_t num_audio_samples = 0;
- size_t accumulated_audio_samples = 0;
+ int accumulated_audio_samples = 0;
char* audio_byte_buffer = reinterpret_cast<char*>(output_buffer_.get());
@@ -137,8 +137,8 @@ void WebRtcAudioDeviceImpl::OnRenderError() {
}
void WebRtcAudioDeviceImpl::Capture(const std::vector<float*>& audio_data,
- size_t number_of_frames,
- size_t audio_delay_milliseconds,
+ int number_of_frames,
+ int audio_delay_milliseconds,
double volume) {
DCHECK_LE(number_of_frames, input_buffer_size());
#if defined(OS_WIN) || defined(OS_MACOSX)
@@ -178,7 +178,8 @@ void WebRtcAudioDeviceImpl::Capture(const std::vector<float*>& audio_data,
const int samples_per_10_msec = (samples_per_sec / 100);
const int bytes_per_10_msec =
channels * samples_per_10_msec * bytes_per_sample_;
- size_t accumulated_audio_samples = 0;
+ int accumulated_audio_samples = 0;
+
char* audio_byte_buffer = reinterpret_cast<char*>(input_buffer_.get());
// Map internal volume range of [0.0, 1.0] into [0, 255] used by the

Powered by Google App Engine
This is Rietveld 408576698