Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: webkit/media/webmediaplayer_impl.cc

Issue 9826023: Merge AudioRendererImpl and AudioRendererBase; add NullAudioSink (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« media/filters/audio_renderer_base.cc ('K') | « media/media.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/media/webmediaplayer_impl.h" 5 #include "webkit/media/webmediaplayer_impl.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <string> 8 #include <string>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/command_line.h" 12 #include "base/command_line.h"
13 #include "base/message_loop_proxy.h" 13 #include "base/message_loop_proxy.h"
14 #include "base/metrics/histogram.h" 14 #include "base/metrics/histogram.h"
15 #include "media/audio/null_audio_sink.h"
15 #include "media/base/filter_collection.h" 16 #include "media/base/filter_collection.h"
16 #include "media/base/limits.h" 17 #include "media/base/limits.h"
17 #include "media/base/media_log.h" 18 #include "media/base/media_log.h"
18 #include "media/base/media_switches.h" 19 #include "media/base/media_switches.h"
19 #include "media/base/pipeline.h" 20 #include "media/base/pipeline.h"
20 #include "media/base/video_frame.h" 21 #include "media/base/video_frame.h"
21 #include "media/filters/null_audio_renderer.h" 22 #include "media/filters/audio_renderer_base.h"
22 #include "media/filters/video_renderer_base.h" 23 #include "media/filters/video_renderer_base.h"
23 #include "third_party/WebKit/Source/WebKit/chromium/public/WebVideoFrame.h" 24 #include "third_party/WebKit/Source/WebKit/chromium/public/WebVideoFrame.h"
24 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h" 25 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
25 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h" 26 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebRect.h"
26 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebSize.h" 27 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebSize.h"
27 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURL.h" 28 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURL.h"
28 #include "v8/include/v8.h" 29 #include "v8/include/v8.h"
29 #include "webkit/media/buffered_data_source.h" 30 #include "webkit/media/buffered_data_source.h"
30 #include "webkit/media/filter_helpers.h" 31 #include "webkit/media/filter_helpers.h"
31 #include "webkit/media/webmediaplayer_delegate.h" 32 #include "webkit/media/webmediaplayer_delegate.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 // Create default video renderer. 149 // Create default video renderer.
149 scoped_refptr<media::VideoRendererBase> video_renderer = 150 scoped_refptr<media::VideoRendererBase> video_renderer =
150 new media::VideoRendererBase( 151 new media::VideoRendererBase(
151 base::Bind(&WebMediaPlayerProxy::Repaint, proxy_), 152 base::Bind(&WebMediaPlayerProxy::Repaint, proxy_),
152 base::Bind(&WebMediaPlayerProxy::SetOpaque, proxy_.get()), 153 base::Bind(&WebMediaPlayerProxy::SetOpaque, proxy_.get()),
153 true); 154 true);
154 filter_collection_->AddVideoRenderer(video_renderer); 155 filter_collection_->AddVideoRenderer(video_renderer);
155 proxy_->set_frame_provider(video_renderer); 156 proxy_->set_frame_provider(video_renderer);
156 157
157 // Create default audio renderer. 158 // Create default audio renderer.
158 filter_collection_->AddAudioRenderer(new media::NullAudioRenderer()); 159 filter_collection_->AddAudioRenderer(
160 new media::AudioRendererBase(new media::NullAudioSink()));
159 } 161 }
160 162
161 WebMediaPlayerImpl::~WebMediaPlayerImpl() { 163 WebMediaPlayerImpl::~WebMediaPlayerImpl() {
162 DCHECK_EQ(main_loop_, MessageLoop::current()); 164 DCHECK_EQ(main_loop_, MessageLoop::current());
163 Destroy(); 165 Destroy();
164 media_log_->AddEvent( 166 media_log_->AddEvent(
165 media_log_->CreateEvent(media::MediaLogEvent::WEBMEDIAPLAYER_DESTROYED)); 167 media_log_->CreateEvent(media::MediaLogEvent::WEBMEDIAPLAYER_DESTROYED));
166 168
167 if (delegate_) 169 if (delegate_)
168 delegate_->PlayerGone(this); 170 delegate_->PlayerGone(this);
(...skipping 724 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 return audio_source_provider_; 895 return audio_source_provider_;
894 } 896 }
895 897
896 void WebMediaPlayerImpl::IncrementExternallyAllocatedMemory() { 898 void WebMediaPlayerImpl::IncrementExternallyAllocatedMemory() {
897 DCHECK_EQ(main_loop_, MessageLoop::current()); 899 DCHECK_EQ(main_loop_, MessageLoop::current());
898 incremented_externally_allocated_memory_ = true; 900 incremented_externally_allocated_memory_ = true;
899 v8::V8::AdjustAmountOfExternalAllocatedMemory(kPlayerExtraMemory); 901 v8::V8::AdjustAmountOfExternalAllocatedMemory(kPlayerExtraMemory);
900 } 902 }
901 903
902 } // namespace webkit_media 904 } // namespace webkit_media
OLDNEW
« media/filters/audio_renderer_base.cc ('K') | « media/media.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698