Remove code to keep obsolete content settings patterns pref in sync.

Remove code to keep obsolete content settings patterns pref in sync with the new preference.


BUG=101877
TEST=PrefProvider*,HostContentSettingsMap*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129592

[markusheintz_, 2012-03-23 11:01:48]

Please review this CL. Thanks

[Bernhard Bauer, 2012-03-23 11:40:15]

lgtm

http://codereview.chromium.org/9826020/diff/4003/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/9826020/diff/4003/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:261: if (*name
== prefs::kContentSettingsPatternPairs) {
If there's no need to do anything special, you can remove this if-clause.

[markusheintz_, 2012-03-23 11:56:51]

Thanks a lot for the fast review.

Checkout how I addressed your comment.

http://codereview.chromium.org/9826020/diff/4003/chrome/browser/content_setti...
File chrome/browser/content_settings/content_settings_pref_provider.cc (right):

http://codereview.chromium.org/9826020/diff/4003/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_pref_provider.cc:261: if (*name
== prefs::kContentSettingsPatternPairs) {
On 2012/03/23 11:40:15, Bernhard Bauer wrote:
> If there's no need to do anything special, you can remove this if-clause.

I moved the inverted condition to the final else. and removed the if.

[Bernhard Bauer, 2012-03-23 12:02:24]

ok, still lgtm :)

[commit-bot: I haz the power, 2012-03-28 16:23:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/markusheintz@chromium.org/9826020/1005

[commit-bot: I haz the power, 2012-03-28 20:20:18]

Try job failure for 9826020-1005 (retry) (retry) on win_rel for step
"browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...