Remove extra dependencies of ltk.ui.refactoring

Remove extra dependencies of ltk.ui.refactoring


Hide org.eclipse.compare contributions


R=pquitslund@google.com,messick@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5765

[pquitslund, 2012-03-23 00:23:24]

Thanks for jumping on this!

Could you explain what you did to remove the dependencies?  That is, did you
just edit manifests or did you modify source (and recompile) as well?

https://chromiumcodereview.appspot.com/9826019/diff/1/editor/tools/plugins/co...
File editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml (right):

https://chromiumcodereview.appspot.com/9826019/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml:209:
pattern="org\.eclipse\.compare.*">
Sweet.  Can we/do we need to do something similar to suppress the top-level
Refactor menu contribution?  For now, anyway, I think we want to make it go away
(since it's not expected to work).

[scheglov, 2012-03-23 01:33:32]

On 2012/03/23 00:23:24, pquitslund wrote:
> Thanks for jumping on this!
> 
> Could you explain what you did to remove the dependencies?  That is, did you
> just edit manifests or did you modify source (and recompile) as well?

  I've only changed manifest.mf and plugin.xml files and removed requiring team
bundles and extensions to team points.


> 
>
https://chromiumcodereview.appspot.com/9826019/diff/1/editor/tools/plugins/co...
> File editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml (right):
> 
>
https://chromiumcodereview.appspot.com/9826019/diff/1/editor/tools/plugins/co...
> editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml:209:
> pattern="org\.eclipse\.compare.*">
> Sweet.  Can we/do we need to do something similar to suppress the top-level
> Refactor menu contribution?  For now, anyway, I think we want to make it go
away
> (since it's not expected to work).

  We don't show Refactor menu right now.
  I've just tested latest build.

[pquitslund, 2012-03-23 03:31:07]

On 2012/03/23 01:33:32, scheglov wrote:
> On 2012/03/23 00:23:24, pquitslund wrote:
> > Thanks for jumping on this!
> > 
> > Could you explain what you did to remove the dependencies?  That is, did you
> > just edit manifests or did you modify source (and recompile) as well?
> 
>   I've only changed manifest.mf and plugin.xml files and removed requiring
team
> bundles and extensions to team points.

Good deal.  Thanks for the clarification.

> 
> 
> > 
> >
>
https://chromiumcodereview.appspot.com/9826019/diff/1/editor/tools/plugins/co...
> > File editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/9826019/diff/1/editor/tools/plugins/co...
> > editor/tools/plugins/com.google.dart.tools.deploy/plugin.xml:209:
> > pattern="org\.eclipse\.compare.*">
> > Sweet.  Can we/do we need to do something similar to suppress the top-level
> > Refactor menu contribution?  For now, anyway, I think we want to make it go
> away
> > (since it's not expected to work).
> 
>   We don't show Refactor menu right now.
>   I've just tested latest build.

Great.  Thanks!

[pquitslund, 2012-03-23 03:31:20]

lgtm

[messick, 2012-03-23 03:41:36]

lgtm