Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 9823001: chromeos top directory (Closed)

Created:
8 years, 9 months ago by oshima
Modified:
8 years, 9 months ago
Reviewers:
stevenjb, Daniel Erat, zel
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org, DaveMoore
Visibility:
Public.

Description

chromeos top directory BUG=119298 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128074

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ash/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A chromeos/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A chromeos/OWNERS View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
8 years, 9 months ago (2012-03-21 21:20:54 UTC) #1
stevenjb
lgtm
8 years, 9 months ago (2012-03-21 21:22:00 UTC) #2
zel
http://codereview.chromium.org/9823001/diff/4001/chromeos/OWNERS File chromeos/OWNERS (right): http://codereview.chromium.org/9823001/diff/4001/chromeos/OWNERS#newcode4 chromeos/OWNERS:4: oshima@chromium.org add derat@ and satorux@
8 years, 9 months ago (2012-03-21 21:24:21 UTC) #3
zel
LGTM other than that comment above
8 years, 9 months ago (2012-03-21 21:25:56 UTC) #4
Daniel Erat
lgtm
8 years, 9 months ago (2012-03-21 21:29:37 UTC) #5
oshima
8 years, 9 months ago (2012-03-21 21:31:35 UTC) #6
On 2012/03/21 21:24:21, zel wrote:
> http://codereview.chromium.org/9823001/diff/4001/chromeos/OWNERS
> File chromeos/OWNERS (right):
> 
> http://codereview.chromium.org/9823001/diff/4001/chromeos/OWNERS#newcode4
> chromeos/OWNERS:4: mailto:oshima@chromium.org
> add derat@ and satorux@

done.

Powered by Google App Engine
This is Rietveld 408576698