Issue 9817020: Linux: Fix the build for Ubuntu Precise.

Issue 9817020: Linux: Fix the build for Ubuntu Precise. (Closed)

Created:
8 years, 9 months ago by Lei Zhang

Modified:
8 years, 9 months ago

Reviewers:
tony, Wez, Elliot Glaysher, Jamie, jianli

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, Dmitry Lomov (no reviews), jennb, simonmorris+watch_chromium.org, hclam+watch_chromium.org, sergeyu+watch_chromium.org, dhollowa+watch_chromium.org, amit, sanjeevr, Dmitry Titov, jianli, garykac+watch_chromium.org, wez+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, dcheng, alexeypa+watch_chromium.org, Andrei, garykac

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux: Fix the build for Ubuntu Precise. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128133

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -17 lines)			Patch
M	chrome/browser/ui/panels/panel_overflow_browsertest.cc	View	4 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/webdata/web_database_migration_unittest.cc	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	remoting/host/local_input_monitor_thread_linux.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/glue/webcursor_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

jianli: panels + OWNER, webdata jamiewalch: remoting + OWNER erg: webkit tony: webkit OWNER https://chromiumcodereview.appspot.com/9817020/diff/1/remoting/host/local_input_monitor_thread_linux.cc ...

8 years, 9 months ago (2012-03-21 23:16:43 UTC) #1

Elliot Glaysher

I see. So while GdkPixbufs can use g_object_unref, cursors can't. That's what I was doing ...

8 years, 9 months ago (2012-03-21 23:21:45 UTC) #3

Wez

remoting/ LGTM, but note that when garykac@ (CC'd) produced a patch for this change, it ...

8 years, 9 months ago (2012-03-21 23:37:59 UTC) #4

Lei Zhang

8 years, 9 months ago (2012-03-22 00:02:06 UTC) #6

On 2012/03/21 23:37:59, Wez wrote:
> remoting/ LGTM, but note that when garykac@ (CC'd) produced a patch for this
> change, it wouldn't compile with our current build-deps.

Looks like it built on the linux_rel trybot.

Expand Messages | Collapse Messages