Created a new class SpdyTestStateHelper to serve as a helper to manage the state of a number of SPD…

net/spdy/spdy_test_util_spdy2.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_test_util_spdy2.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_network_transaction.h"
 #include "net/http/http_server_properties_impl.h"
 #include "net/spdy/buffered_spdy_framer.h"
 #include "net/spdy/spdy_http_utils.h"
+#include "net/spdy/spdy_session.h"
 
 namespace net {
 namespace test_spdy2 {
 
 // Chop a frame into an array of MockWrites.
 // |data| is the frame to chop.
 // |length| is the length of the frame to chop.
 // |num_chunks| is the number of chunks to create.
 MockWrite* ChopWriteFrame(const char* data, int length, int num_chunks) {
   MockWrite* chunks = new MockWrite[num_chunks];
@@ skipping 971 matching lines @@
     spdy::CONTROL_FLAG_FIN,       // Control Flags
     false,                        // Compressed
     spdy::INVALID,                // Status
     NULL,                         // Data
     0,                            // Length
     spdy::DATA_FLAG_NONE          // Data Flags
   };
   return kHeader;
 }
 
+SpdyTestStateHelper::SpdyTestStateHelper() {

[willchan no longer on Chromium, 2012/03/22 01:21:04]

I dunno, it would feel cleaner to me if there were an accessor so you can store
the original value of the global variable and then restore it at the end, rather
than just forcibly writing a constant value in the destructor.

[Ryan Hamilton, 2012/03/22 02:38:35]

Added a TODO.  I wonder if a ResetStatics() method (like we have in SpdySession)
might be cleaner.  That helps prevent the damage a poorly written test can do.

+  // Pings can be non-deterministic, because they are sent via timer.
+  SpdySession::set_enable_ping_based_connection_checking(false);
+  // Compression is per-session which makes it impossible to create
+  // SPDY frames with static methods.
+  spdy::SpdyFramer::set_enable_compression_default(false);
+}
+
+SpdyTestStateHelper::~SpdyTestStateHelper() {
+  SpdySession::ResetStaticSettingsToInit();
+  spdy::SpdyFramer::set_enable_compression_default(true);
+}
+
 }  // namespace test_spdy2
 }  // namespace net