Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 9817002: Add OS::GetCurrentProcessId and prepend output from trace-gc with the current pid (Closed)

Created:
8 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add OS::GetCurrentProcessId and prepend output from trace-gc with the current pid BUG=none TEST=manual Committed: https://code.google.com/p/v8/source/detail?r=12032

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -65 lines) Patch
M src/heap.cc View 1 2 6 chunks +55 lines, -55 lines 0 comments Download
M src/incremental-marking.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/incremental-marking.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M src/incremental-marking-inl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/v8utils.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/v8utils.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-platform-linux.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-platform-win32.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
plz review do you have some kind of trybots? I don't feel like compiling this ...
8 years, 9 months ago (2012-03-21 09:05:30 UTC) #1
Michael Starzinger
There are several --trace-gc lines missing which do not get the PID prepended. So this ...
8 years, 8 months ago (2012-04-12 14:37:48 UTC) #2
jochen (gone - plz use gerrit)
On 2012/04/12 14:37:48, Michael Starzinger wrote: > There are several --trace-gc lines missing which do ...
8 years, 5 months ago (2012-07-02 11:48:00 UTC) #3
Michael Starzinger
General feedback: I think it would be good to introduce a PrintPID() or PrintPIDPrefix() method ...
8 years, 5 months ago (2012-07-06 14:00:05 UTC) #4
jochen (gone - plz use gerrit)
On 2012/07/06 14:00:05, Michael Starzinger wrote: > General feedback: I think it would be good ...
8 years, 5 months ago (2012-07-09 07:32:31 UTC) #5
Michael Starzinger
8 years, 5 months ago (2012-07-10 12:27:32 UTC) #6
LGTM. I'll land this for you.

Powered by Google App Engine
This is Rietveld 408576698