Issue 9815015: Revert 127988 - net: update certificates for TestKnownRoot and PublicKeyHashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9815015: Revert 127988 - net: update certificates for TestKnownRoot and PublicKeyHashes. (Closed)

Created:
8 years, 9 months ago by Wez

Modified:
8 years, 9 months ago

Reviewers:
agl, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 127988 - net: update certificates for TestKnownRoot and PublicKeyHashes. This CL seems to have broken the Win & Win Aura builds. I reused the Comodo certificate since it's valid for > year and it's the last one that I touched. BUG=111893 TEST=net_unittests TBR=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127993

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -38 lines)			Patch
M	net/base/test_certificate_data.h	View	1 chunk	+0 lines, -8 lines	1 comment	Download
M	net/base/x509_certificate_unittest.cc	View	4 chunks	+74 lines, -32 lines	1 comment	Download
A +	net/data/ssl/certificates/nist.der	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	net/data/ssl/certificates/nist_intermediate.der	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

8 years, 9 months ago (2012-03-21 19:47:36 UTC) #3

https://chromiumcodereview.appspot.com/9815015/diff/1/net/base/test_certifica...
File net/base/test_certificate_data.h (left):

https://chromiumcodereview.appspot.com/9815015/diff/1/net/base/test_certifica...
net/base/test_certificate_data.h:458: static const char kComodoSPKIHash[] = {
unsigned char VARIABLE_IS_NOT_USED

https://chromiumcodereview.appspot.com/9815015/diff/1/net/base/x509_certifica...
File net/base/x509_certificate_unittest.cc (left):

https://chromiumcodereview.appspot.com/9815015/diff/1/net/base/x509_certifica...
net/base/x509_certificate_unittest.cc:855: // Bug 111893: This test needs a new
certificate.
agl: When you reland, can you nuke this line as well

Expand Messages | Collapse Messages