Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: dart/frog/leg/resolver.dart

Issue 9815003: Implement unresolved super-send (but ignoring arguments). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Triaged Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/elements/elements.dart ('k') | dart/frog/leg/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/resolver.dart
diff --git a/dart/frog/leg/resolver.dart b/dart/frog/leg/resolver.dart
index 0a1b02284458d0a88696c9c67d4ff4c73fe4d884..245f6b28c97fa37df4affe246e36c2dde476dfeb 100644
--- a/dart/frog/leg/resolver.dart
+++ b/dart/frog/leg/resolver.dart
@@ -768,9 +768,13 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
if (name.stringValue === 'this') {
error(node.selector, MessageKind.GENERIC, ["expected an identifier"]);
} else if (node.isSuperCall) {
- if (isUserDefinableOperator(name.stringValue)) {
- name = Elements.constructOperatorName(const SourceString('operator'),
- name);
+ if (node.isOperator) {
+ if (isUserDefinableOperator(name.stringValue)) {
+ name = Elements.constructOperatorName(const SourceString('operator'),
+ name);
+ } else {
+ error(node.selector, MessageKind.ILLEGAL_SUPER_SEND, [name]);
+ }
}
if (!inInstanceContext) {
error(node.receiver, MessageKind.NO_INSTANCE_AVAILABLE, [name]);
« no previous file with comments | « dart/frog/leg/elements/elements.dart ('k') | dart/frog/leg/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698