Issue 9814031: views/bookmarks: Convert BookmarkEditorView from Menu2 API to MenuModelApdater/MenuRunner API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9814031: views/bookmarks: Convert BookmarkEditorView from Menu2 API to MenuModelApdater/MenuRunner API. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views/bookmarks: Convert BookmarkEditorView from Menu2 API to MenuModelApdater/MenuRunner API. This patches removes the usage of the deprecated Menu2 API and makes it work under use_aura=1. BUG=117092 TEST=chromeos=1, open the bookmark editor dialog, right click on any folder, you should see the context menu with 3 items, and everything should work as before. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128264

Patch Set 1 #

Patch Set 2 : fix win #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -23 lines)			Patch
	M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc	View	1	4 chunks	+23 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages