Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 9814030: get rid of old options pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index 9cc358f8ea606aaef0b3d6014266091b46a28ca8..f960d372165ef9947df7cbaa501eac43551d9491 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -228,14 +228,14 @@ WebUIFactoryFunction GetWebUIFactoryFunction(content::WebUI* web_ui,
// These pages are implemented with native UI elements on Android.
if (url.host() == chrome::kChromeUIDownloadsHost)
return &NewWebUI<DownloadsUI>;
+ // Android doesn't use the Options pages.
Dan Beam 2012/03/23 03:25:31 merge conflict?
if (url.host() == chrome::kChromeUIFeedbackHost)
return &NewWebUI<FeedbackUI>;
if (url.host() == chrome::kChromeUIHelpFrameHost)
return &NewWebUI<HelpUI>;
if (url.host() == chrome::kChromeUISettingsFrameHost)
return &NewWebUI<options2::OptionsUI>;
- if (url.host() == chrome::kChromeUISettingsHost)
- return &NewWebUI<OptionsUI>;
+ // Android doesn't support print/print-preview.
if (url.host() == chrome::kChromeUIPrintHost &&
!g_browser_process->local_state()->GetBoolean(
prefs::kPrintPreviewDisabled)) {
@@ -480,14 +480,11 @@ RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
return FlashUI::GetFaviconResourceBytes();
#if !defined(OS_ANDROID)
- // Android uses the native download manager
+ // Android uses the native download manager.
if (page_url.host() == chrome::kChromeUIDownloadsHost)
return DownloadsUI::GetFaviconResourceBytes();
- // Android doesn't use the Options/Options2 pages
- if (page_url.host() == chrome::kChromeUISettingsHost)
- return OptionsUI::GetFaviconResourceBytes();
-
+ // Android doesn't use the Options pages.
if (page_url.host() == chrome::kChromeUISettingsFrameHost)
return options2::OptionsUI::GetFaviconResourceBytes();
#endif

Powered by Google App Engine
This is Rietveld 408576698