Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Unified Diff: client/dom/scripts/systemnative.py

Issue 9814012: Proper include forms. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/scripts/generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/systemnative.py
diff --git a/client/dom/scripts/systemnative.py b/client/dom/scripts/systemnative.py
index 504cbf8feeef94a70eecc79db9e120a95558e9e0..1cedf1b46ed8685361ae78a6d4af5731eba415a2 100644
--- a/client/dom/scripts/systemnative.py
+++ b/client/dom/scripts/systemnative.py
@@ -273,7 +273,7 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):
' goto fail;\n'
' }\n'
' Document* document = domWindow->document();\n')
- self._cpp_impl_includes.add('DOMWindow')
+ self._cpp_impl_includes.add('"DOMWindow.h"')
arguments.append('document')
create_function = 'createForJSConstructor'
if 'CallWith' in self._interface.ext_attrs:
@@ -413,11 +413,11 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):
return False
if call_with == 'ScriptArguments|CallStack':
- self._cpp_impl_includes.add('DOMWindow')
- self._cpp_impl_includes.add('ScriptArguments')
- self._cpp_impl_includes.add('ScriptCallStack')
- self._cpp_impl_includes.add('V8Proxy')
- self._cpp_impl_includes.add('v8')
+ self._cpp_impl_includes.add('"DOMWindow.h"')
+ self._cpp_impl_includes.add('"ScriptArguments.h"')
+ self._cpp_impl_includes.add('"ScriptCallStack.h"')
+ self._cpp_impl_includes.add('"V8Proxy.h"')
+ self._cpp_impl_includes.add('"v8.h"')
parameter_definitions_emitter.Emit(
'\n'
' v8::HandleScope handleScope;\n'
@@ -770,7 +770,7 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):
'onmouseup', 'onresize', 'onscroll', 'onunload']
if self._interface.id.startswith('SVG') and not attr.id in svg_exceptions:
namespace = 'SVGNames'
- self._cpp_impl_includes.add(namespace)
+ self._cpp_impl_includes.add('"%s.h"' % namespace)
attribute_name = attr.ext_attrs['Reflect'] or attr.id.lower()
return 'WebCore::%s::%sAttr' % (namespace, attribute_name)
@@ -831,10 +831,10 @@ class NativeImplementationGenerator(systemwrapping.WrappingInterfaceGenerator):
if 'ImplementedBy' in attributes:
arguments.insert(0, 'receiver')
- self._cpp_impl_includes.add(attributes['ImplementedBy'])
+ self._cpp_impl_includes.add('"%s.h"' % attributes['ImplementedBy'])
return emitter.Format(invocation_template,
FUNCTION_CALL='%s(%s)' % (function_expression, ', '.join(arguments)))
def _GenerateCPPIncludes(includes):
- return ''.join(['#include "%s.h"\n' % include for include in includes])
+ return ''.join(['#include %s\n' % include for include in includes])
« no previous file with comments | « client/dom/scripts/generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698