third_party/libva/README.chromium - Issue 9814001: Add VAVDA, the VAAPI Video Decode Accelerator for Intel CPUs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libva/README.chromium

Issue 9814001: Add VAVDA, the VAAPI Video Decode Accelerator for Intel CPUs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: libva
	Ami GONE FROM CHROMIUM 2012/03/21 13:16:24 Is there some reason to copy libva into third_part Is there some reason to copy libva into third_party instead of pulling it in via DEPS? Hint: I think the answer is "no", unless you have local modifications that must be applied to the third-party code that can't be upstreamed. If that's the case then those modifications deserve description here. I hope you can avoid this with a suitable addition to DEPS (and a corresponding crbug to get a git mirror set up for UsingNewGit to work) Pawel Osciak 2012/03/21 18:40:35 We are actually thinking with Stephane about this Show quoted text On 2012/03/21 13:16:24, Ami Fischman wrote: > Is there some reason to copy libva into third_party instead of pulling it in via > DEPS? > > Hint: I think the answer is "no", unless you have local modifications that must > be applied to the third-party code that can't be upstreamed. We are actually thinking with Stephane about this to optimize the driver ourselves, but not for now at least. Show quoted text > If that's the case > then those modifications deserve description here. > I hope you can avoid this with a suitable addition to DEPS (and a corresponding > crbug to get a git mirror set up for UsingNewGit to work) Ami GONE FROM CHROMIUM 2012/03/22 17:01:36 Then please revert the libva part of this CL and a Show quoted text On 2012/03/21 18:40:35, posciak wrote: > On 2012/03/21 13:16:24, Ami Fischman wrote: > > Is there some reason to copy libva into third_party instead of pulling it in > via > > DEPS? > > > > Hint: I think the answer is "no", unless you have local modifications that > must > > be applied to the third-party code that can't be upstreamed. > > We are actually thinking with Stephane about this to optimize the driver > ourselves, but not for now at least. Then please revert the libva part of this CL and add it to DEPS instead (after asking chrome-infrastructure-team to create a git mirror repo).
	2 URL: http://freedesktop.org/wiki/Software/vaapi

	3 Version: 1.0.14

	4 Security Critical: yes
	Ami GONE FROM CHROMIUM 2012/03/21 13:16:24 Do you know what this line does? (I don't) Do you know what this line does? (I don't) Pawel Osciak 2012/03/21 18:40:35 No, so erring on the side of caution. :) But since Show quoted text On 2012/03/21 13:16:24, Ami Fischman wrote: > Do you know what this line does? (I don't) No, so erring on the side of caution. :) But since it's executed on the GPU thread, I thought this would be wise...
	5

	6 Description:

	7 This library is used to interface with the Intel graphics driver for hardware

	8 accelerated video decoding.

	9

OLD	NEW

« content/renderer/render_view_impl.cc ('K') | « content/renderer/render_view_impl.cc ('k') | third_party/libva/va/va.h » ('j') | ui/gfx/gl/gl_context_egl.h » ('J')