Add VAVDA, the VAAPI Video Decode Accelerator for Intel CPUs.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 2134 matching lines @@
     // from the perspective of the audio renderer.
     audio_source_provider = new RenderAudioSourceProvider();
 
     // Add the chrome specific audio renderer, using audio_source_provider
     // as the sink.
     AudioRendererImpl* audio_renderer =
         new AudioRendererImpl(audio_source_provider);
     collection->AddAudioRenderer(audio_renderer);
   }
 
-  // Currently only cros/arm has any HW video decode support in
+  // Currently only cros has any HW video decode support in
   // GpuVideoDecodeAccelerator so we don't even try to use it on other
   // platforms.  This is a startup-time optimization.  When new VDA
   // implementations are added, relax the #if above.

[Ami GONE FROM CHROMIUM, 2012/03/21 13:16:24]

s/above/below/

[Pawel Osciak, 2012/04/05 10:37:20]

Done.

-#if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL)
+#if defined(OS_CHROMEOS) \
+  && (defined(ARCH_CPU_ARMEL) || defined(ARCH_CPU_X86_FAMILY))

[Ami GONE FROM CHROMIUM, 2012/03/21 13:16:24]

&& belongs on previous line

[Ami GONE FROM CHROMIUM, 2012/03/21 13:16:24]

are there any cros platforms *other* than x86 & arm?

[Pawel Osciak, 2012/03/21 18:40:35]

Not that I am aware of. Wanted to be extra safe. Drop it?

[Ami GONE FROM CHROMIUM, 2012/03/22 17:01:36]

Yes please.

[Pawel Osciak, 2012/04/05 10:37:20]

Done.

+  // Currently only cros has any HW video decode support in

[Ami GONE FROM CHROMIUM, 2012/03/21 13:16:24]

delete?

[Pawel Osciak, 2012/03/21 18:40:35]

Your call, was here before :)

[Ami GONE FROM CHROMIUM, 2012/03/22 17:01:36]

You duplicated the pre-existing line.
(note this is a copy of l.2155; this copy should be deleted, the other one
should stay)

[Pawel Osciak, 2012/04/05 10:37:20]

Done.

   // Note we don't actually use the result of this blind down-cast unless it's
   // valid (not NULL and of the right type).
   WebGraphicsContext3DCommandBufferImpl* context3d =

[Ami GONE FROM CHROMIUM, 2012/03/21 13:16:24]

Why bother going all the way to the GPU process to find out VAAPI is disabled? 
I'd check for the enable flag here, instead.
(that would also let you not propagate the enable flag to the GPU process,
reverting gpu_process_host.cc)

[Pawel Osciak, 2012/04/05 10:37:20]

Do we want to have one common flag then for acceleration on ARM and x86, as well
as on cros and on Linux?

       static_cast<WebGraphicsContext3DCommandBufferImpl*>(
           webview()->graphicsContext3D());
   if (context_is_web_graphics_context_3d_command_buffer_impl_ && context3d) {
     MessageLoop* factories_loop =
         RenderThreadImpl::current()->compositor_thread() ?
         RenderThreadImpl::current()->compositor_thread()->GetWebThread()
             ->message_loop() :
         MessageLoop::current();
     GpuChannelHost* gpu_channel_host =
         RenderThreadImpl::current()->EstablishGpuChannelSync(
@@ skipping 3012 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_.get());
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this));
 #endif
 }