Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 9812042: Revert 106232 - .: Manual test of number of resize events emitted during page generation. (Closed)

Created:
8 years, 9 months ago by karen
Modified:
8 years, 9 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Revert 106232 - .: Manual test of number of resize events emitted during page generation. https://bugs.webkit.org/show_bug.cgi?id=77212 Is needed to test if too many resize events are send when using fixed layout, and needs to be a manual test because the test framework does not currently support testing fixed layout. Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com>; on 2012-01-30 Reviewed by Kenneth Rohde Christiansen. * ManualTests/resize-events.html: Added. Source/WebCore: Only send resize events when layout size changes. https://bugs.webkit.org/show_bug.cgi?id=77212 When using fixed layout the widget size is the size of content, therefore resize checks must check against layoutsize and not widget size. Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com>; on 2012-01-30 Reviewed by Kenneth Rohde Christiansen. Needs to be manual tests because the test framework does not currently support testing fixed layout. Tests: ManualTests/resize-events.html * page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks): TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=111646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -50 lines) Patch
D ManualTests/resize-events.html View 1 chunk +0 lines, -48 lines 0 comments Download
M Source/WebCore/page/FrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 9 months ago (2012-03-22 03:25:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698