Fixed OOBE start up for Linux desktop use cases.

Fixed OOBE start up for Linux desktop use cases - stub user case.

BUG=none
TEST=make sure OOBE is back on your workstation

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128151

[sadrul, 2012-03-22 02:59:11]

Fixes for me. LGTM

[rkc, 2012-03-22 03:02:31]

Fixes the login for now, so definitely LGTM.

https://chromiumcodereview.appspot.com/9812039/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://chromiumcodereview.appspot.com/9812039/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:87:
!UserManager::Get()->IsLoggedInAsStub() &&
UserManager::Get()->IsUserLoggedIn() should not be true; but for now this fixes
the login problem.

[zel, 2012-03-22 03:04:35]

+nkostylev,pastarmovj as fyi

I suspect this regression was caused by
https://src.chromium.org/viewvc/chrome?view=rev&revision=127946.

[oshima, 2012-03-22 03:04:45]

lgtm

[pastarmovj, 2012-03-22 10:39:24]

Just a reply on Rahul's comment.

https://chromiumcodereview.appspot.com/9812039/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):

https://chromiumcodereview.appspot.com/9812039/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:87:
!UserManager::Get()->IsLoggedInAsStub() &&
On 2012/03/22 03:02:34, Rahul Chaturvedi wrote:
> UserManager::Get()->IsUserLoggedIn() should not be true; but for now this
fixes
> the login problem.

This was my first thought too but after discussing that with Nikita a bit longer
I agree now that we should treat the stub user as a normal login. Your other fix
should cover all the cases that really should not have a loggedin user and this
fix here makes sure the OOBE flow will be fine as well so as long as we keep the
paradigm of having a stub user on linux then it should as well be properly
registered as being logged in.

[Nikita (slow), 2012-03-22 11:30:32]

On 2012/03/22 10:39:24, pastarmovj wrote:
> Just a reply on Rahul's comment.
> 
>
https://chromiumcodereview.appspot.com/9812039/diff/1/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9812039/diff/1/chrome/browser/ui/webui...
> chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:87:
> !UserManager::Get()->IsLoggedInAsStub() &&
> On 2012/03/22 03:02:34, Rahul Chaturvedi wrote:
> > UserManager::Get()->IsUserLoggedIn() should not be true; but for now this
> fixes
> > the login problem.
> 
> This was my first thought too but after discussing that with Nikita a bit
longer
> I agree now that we should treat the stub user as a normal login. Your other
fix
> should cover all the cases that really should not have a loggedin user and
this
> fix here makes sure the OOBE flow will be fine as well so as long as we keep
the
> paradigm of having a stub user on linux then it should as well be properly
> registered as being logged in.

Yes, what is missing is that when actual sign in on desktop linux happens, stub
instance is set as logged in user.

stub instance could be created in UserManagerImpl ctor but should not be marked
as logged in: Rahul's CL http://codereview.chromium.org/9811031/

[Nikita (slow), 2012-03-22 11:31:19]

lgtm but this change is a proper one:
http://codereview.chromium.org/9811031/

Sorry, I've overlooked such basic scenario on codereview.