Issue 9812038: Revert 128139 - NaCl: Enable hardware exception handling test on 32-bit Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9812038: Revert 128139 - NaCl: Enable hardware exception handling test on 32-bit Windows (Closed)

Created:
8 years, 9 months ago by greggman

Modified:
8 years, 9 months ago

Reviewers:
Mark Seaborn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 128139 - NaCl: Enable hardware exception handling test on 32-bit Windows There are no trybots for 32-bit Windows, so I want to enable the test there separately from implementing 64-bit Windows support to avoid any surprises later. The test for 64-bit Windows is copied from NaCl's buildbot_nacl_integration.py script. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2651 TEST=run_inbrowser_exception_test in nacl_integration Review URL: https://chromiumcodereview.appspot.com/9815026 TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128143

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/test/nacl_test_injection/buildbot_nacl_integration.py	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

8 years, 9 months ago (2012-03-22 02:44:15 UTC) #2

LGTM.  I had tested the change on a 32-bit Windows machine; I'm not yet sure why
the change failed on the 32-bit Windows bot.

Expand Messages | Collapse Messages